Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added regression test #3136

Merged
merged 2 commits into from
Jun 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1687,4 +1687,18 @@ public function testBug10974(): void
$this->analyse([__DIR__ . '/data/bug-10974.php'], []);
}

public function testCountArrayShift(): void
{
$this->analyse([__DIR__ . '/data/count-array-shift.php'], [
[
'Parameter #1 $value of function count expects array|Countable, array|false given.',
10,
],
[
'Parameter #1 $value of function count expects array|Countable, array|false given.',
18,
],
]);
}

}
19 changes: 19 additions & 0 deletions tests/PHPStan/Rules/Functions/data/count-array-shift.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

namespace CountArrayShift;

/** @param array<mixed>|false $a */
function foo($a): void
{
while (count($a) > 0) {
array_shift($a);
}
}

/** @param non-empty-array<mixed>|false $a */
function bar($a): void
{
while (count($a) > 0) {
array_shift($a);
}
}
Loading