CallToFunctionStatementWithoutSideEffectsRule checks the purity of array_filter(), array_map(), and array_reduce()
#3106
+98
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another case which should be tested: phpstan/phpstan#11100 |
staabm
reviewed
May 29, 2024
| @@ -19,6 +19,11 @@ public function noEffect(string $url, $resourceOrNull) | |||
| var_export([], return: true); | |||
| print_r([], return: true); | |||
| highlight_string($url, return: true); | |||
| array_filter([], callback: 'is_string'); | |||
There was a problem hiding this comment.
We should test cases in which the callback is impure, e.g. because of calls to impure functions or access to global variables or similar from within the callable
|
It's not sufficient to handle this in a rule. It needs to be considered in NodeScopeResolver, so that the statements produce or not produce impurePoints. |
…ray_filter(), array_map(), and array_reduce()
zonuexe
force-pushed
the
feature/array-map-filter-sideeffect
branch
from
b19ad33
to
c7a5e59
Compare
|
This is a wrong direction. We need something like |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve phpstan/phpstan#11101
The following functions can also cause side effects via callbacks, but since they are used infrequently and the processing is more complex, it is sufficient to follow the existing functionMetadata.
array_udiff_assoc()array_udiff_uassoc()array_uintersect()array_uintersect_assoc()array_uintersect_uassoc()phpstan-src/resources/functionMetadata.php
Lines 721 to 728 in 66a2fd0