Update return type of spl_autoload_functions on PHP8.0+
#2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
The documentation states that spl_autoload_functions might only return false on PHP versions up to 7.4; it will return an empty array on PHP8+.
ManuelHu
force-pushed
the
return-type-spl_autoload_functions-php8
branch
from
29bf778
to
0b4373f
Compare
|
@ondrejmirtes This (already very old) PR should now be ready for review and merging. I hope I did everythng right for the version specific signatures, at least it seems to work. This might break some custom |
|
This is okay, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP documentation states that
spl_autoload_functionsmight only returnfalseon PHP versions up to 7.4; it will return an empty array on PHP8+.functionMap.phpcontains the PHP 7.4 signature. This is unchanged. Is this correct?functionMap_php80delta.phparrayspecified. Before this PR, PHPStan assumes a return type ofarray(aslist<...>|falsein functionMap.php is not a subtype of the native typearray)This PR also fixes some static analysis errors in PHPStan's source code that resulted from the functionMap changes.