Non-numeric strings in pow() lead to error #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Nov 29, 2023
|
This pull request has been marked as ready for review. |
staabm
commented
Nov 29, 2023
staabm
commented
Nov 29, 2023
staabm
force-pushed
the
fix-exp
branch
2 times, most recently
from
7b2ac0c
to
86acced
Compare
ondrejmirtes
requested changes
Jan 6, 2024
src/Type/ExponentiateHelper.php
Outdated
| new NullType(), | ||
| ]); | ||
| if (!$allowedOperandTypes->isSuperTypeOf($exponent)->yes()) { | ||
| return new ErrorType(); |
There was a problem hiding this comment.
I disagree with returning ErrorType here.
string might still be a numeric-string so it's wrong to return ErrorType for that case.
We just want to prevent the internal error the issue is about.
|
reduced the PR to a minimal fix |
|
Thank you. |
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10125