php8 vs php7 fix

phpstan · Apr 24, 2024 · 1e2cef8 · 1e2cef8
1 parent 2a69a34
commit 1e2cef8
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -191,6 +191,11 @@ public function dataFileAsserts(): iterable
  yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-1014.php');
  yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-pr-339.php');
  yield from $this->gatherAssertTypes(__DIR__ . '/data/pow.php');
+ if (PHP_VERSION_ID >= 80000) {
+ yield from $this->gatherAssertTypes(__DIR__ . '/data/pow-php8.php');
+ } else {
+ yield from $this->gatherAssertTypes(__DIR__ . '/data/pow-php7.php');
+ }
  yield from $this->gatherAssertTypes(__DIR__ . '/data/throw-expr.php');
  yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-5351.php');
 

diff --git a/tests/PHPStan/Analyser/data/pow-php7.php b/tests/PHPStan/Analyser/data/pow-php7.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace PowFunction;
+
+use function PHPStan\Testing\assertType;
+
+assertType('4', '4a' ** 1);
+assertType('0', 'a' ** 1);
diff --git a/tests/PHPStan/Analyser/data/pow-php8.php b/tests/PHPStan/Analyser/data/pow-php8.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace PowFunction;
+
+use function PHPStan\Testing\assertType;
+
+assertType('4', '4a' ** 1);
+assertType('*ERROR*', 'a' ** 1);
diff --git a/tests/PHPStan/Analyser/data/pow.php b/tests/PHPStan/Analyser/data/pow.php
@@ -169,9 +169,6 @@ function doFoo(int $intA, int $intB, string $s, bool $bool, $numericS, float $fl
  assertType('*ERROR*', $s ** $arr);
  assertType('*ERROR*', $s ** []);
 
- assertType('4', '4a' ** 1);
- assertType('*ERROR*', 'a' ** 1);
-
  assertType('1', pow($bool, 0));
  assertType('1', $bool ** '0');
  assertType('1', $bool ** false);