First pass of integrating Sculpin as a blog engine [DO NOT MERGE] #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this. While this did end up showing some deficiencies in the current code base (all of which I entered issues for), I think there is a better solution to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add blog functionality of #22, and is still a work in progress.
Adding this in changed a bit of things and still needs some cleanup, but pushing this up so that (if nothing else) this doesn't get lost, and others can start to look over it.
Sculpin is now used to generate any static pages, as well as markdown-based content like blog posts. Any file that isn't generated by Sculpin will then fall back to
index.phpand the existing Silex infrastructure and run like normal. Both Sculpin and Silex share the same layout and view files so that everything stays in sync.As a word of note, this does add an extra step for setup as mentioned in the README. The
public/directory is now generated by Sculpin and no longer stored in version control, so any changes topublic/index.phpor assets like JS or CSS will need to have the rebuild command run to push changes to thepublic/directory.As a consequence of upgrading packages to satisfy dependencies for Sculpin, this also takes care of #85.