Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix SubscriberList to Subscriber relationship definition by … #312

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ After that has been done, you can run the integration tests:
vendor/bin/phpunit tests/Integration/
```

When changing database relations and entities please ensure the mapping is valid by running:

```bash
bin/console doctrine:schema:validate
```

## Coding Style

Expand Down
5 changes: 5 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ script:
echo "Validating the composer.json";
composer validate --no-check-all --no-check-lock --strict;

- >
echo;
echo "Doctrine database schema validation";
bin/console doctrine:schema:validate;

- >
echo;
echo "Linting all PHP files";
Expand Down
2 changes: 1 addition & 1 deletion src/Domain/Model/Subscription/Subscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class Subscriber implements DomainModel, Identity, CreationDate, ModificationDat

/**
* @var Collection
* @Mapping\ManyToMany(targetEntity="PhpList\Core\Domain\Model\Messaging\SubscriberList", inversedBy="subscribers")
* @Mapping\ManyToMany(targetEntity="PhpList\Core\Domain\Model\Messaging\SubscriberList", mappedBy="subscribers")
* @Mapping\JoinTable(name="phplist_listuser",
* joinColumns={@Mapping\JoinColumn(name="userid")},
* inverseJoinColumns={@Mapping\JoinColumn(name="listid")}
Expand Down