-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change invalid use of @alt on <a> anchor tags #418
base: master
Are you sure you want to change the base?
Conversation
Previously the page stated "PHP 4, PHP 5 and PHP 7 are distributed..." even though PHP 8 has been released. This commit changes the wording to be "Starting with PHP 4, versions of the PHP software are distributed..."
@@ -27,7 +27,7 @@ | |||
|
|||
<ul> | |||
<li> | |||
PHP 4, PHP 5 and PHP 7 are distributed under the | |||
Starting with PHP 4, versions of the PHP software are distributed under the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this was already merged by @nikic. Not sure why it is showing up in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rebase on master.
@@ -198,7 +198,7 @@ | |||
<p> | |||
Set in Paris, on December 8th and 9th 2008, by the | |||
Association Française des Utilisateurs de PHP (French PHP User Group, | |||
<a href="http://www.afup.org/" alt="AFUP">http://www.afup.org/</a>), | |||
<a href="http://www.afup.org/" title="AFUP">http://www.afup.org/</a>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, this file is not used (see 2008.php).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salathe — Understood. I was just updating the code that was there. But it is clear the code has more than a little "lint."
Who can know for sure if that file is needed or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who can know for sure if that file is needed or not?
I know for sure. The 2007.xml
and 2008.xml
files are hangovers from when we used to have all of the XML news for a year in one file: we moved to using the archive/entries/
subfolder in 2008.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salathe — So, for clarity, I can delete that file and include its deletion in this PR?
Changed from invalid @alt attribute on anchor HTML elements to valid @title attribute using the same values used for @alt.
Also fixed on invalid use of a non-existent element and replaced with .