Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FreeBSD CI #16817

Closed
wants to merge 5 commits into from
Closed

Update FreeBSD CI #16817

wants to merge 5 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 15, 2024

FreeBSD 13.2 is no longer supported[1], and apparently the respective Cirrus CI image has been removed. We update to FreeBSD 13.3.

[1] https://www.freebsd.org/security/#sup
[2] https://github.com/php/php-src/runs/33044888209

FreeBSD 13.2 is no longer supported[1], and apparently the respective
Cirrus CI image has been removed.  We update to FreeBSD 13.3.

[1] <https://www.freebsd.org/security/#sup>
[2] <https://github.com/php/php-src/runs/33044888209>
@iluuu1994
Copy link
Member

For context: f2f656c. Apart from removing -Werror, ext/curl/tests/curl_setopt_ssl.phpt might need to be updated.

@cmb69
Copy link
Member Author

cmb69 commented Nov 15, 2024

Ah, missed your comment @iluuu1994. Thanks, I'll have a look.

We need to cater to 13.3 soon, though, since supports end end of the year. And that will go on. Basically, this is the same issue as with homebrew – we should not rely on rolling releases for security branches.

@iluuu1994
Copy link
Member

@cmb69 Ignoring specific errors works for me too, thanks!

@iluuu1994
Copy link
Member

iluuu1994 commented Nov 15, 2024

We need to cater to 13.3 soon, though, since supports end end of the year. And that will go on. Basically, this is the same issue as with homebrew – we should not rely on rolling releases for security branches.

I agree, but how do we do this in practice? It makes sense to test against the newest version on master. I suppose we can downgrade to the latest LTS once we reach the security phase? Or we just stick to the LTS I guess. That's what we do for Ubuntu.

cmb69 and others added 2 commits November 15, 2024 15:44
13.2 is going to be EOL.

close phpGH-13622

(cherry picked from commit f2f656c)
@cmb69
Copy link
Member Author

cmb69 commented Nov 15, 2024

I think it's best to use LTS whereever possible (except maybe for nightly master); unfortunately, there seems to be no LTS for Homebrew and (Cirrus CI) FreeBSD.

@iluuu1994
Copy link
Member

That's unfortunate... Maybe it's time to finally try QEMU. Running freebsd in nightly (and maybe push with an opt-in flag like [FreeBSD]) might be enough.

@cmb69
Copy link
Member Author

cmb69 commented Nov 15, 2024

Cirrus CI runs FreeBSD on amd64, so there shouldn't be the need for QEMU. Still, setting up a FreeBSD might take a long time (a couple of years I had a VirtualBox FreeBSD, and it compiled everything from scratch; don't know if they have binary downloads nowadays).

Anyhow, FreeBSD passes now! \o/

@cmb69
Copy link
Member Author

cmb69 commented Nov 15, 2024

Running freebsd in nightly (and maybe push with an opt-in flag like [FreeBSD]) might be enough.

See ##16119.

@iluuu1994
Copy link
Member

iluuu1994 commented Nov 15, 2024

FWIU, QEMU can do virtualization, so there should be no benefit to using something like VirtualBox. I'm trying this now: https://github.com/vmactions/freebsd-vm

@devnexen
Copy link
Member

FWIU, QEMU can do virtualization, so there should be no benefit over using something like VirtualBox. I'm trying this now: https://github.com/vmactions/freebsd-vm

Not a bad idea I use it on one of my projects. It is slow (3mn vs < 5 sec for Linux part) but it can work.

@iluuu1994
Copy link
Member

I understand booting the VM is slow, is compilation & testing itself also slow?

@devnexen
Copy link
Member

The difference is less visible but my workload is far lower than php's tough :) you ll see soon enough anyway.

@iluuu1994
Copy link
Member

Indeed 🙂 I can share results in a few hours.

@cmb69 cmb69 marked this pull request as ready for review November 15, 2024 15:55
@iluuu1994
Copy link
Member

iluuu1994 commented Nov 15, 2024

Some tests fail, which I'll have to look at, but the compilation/testing itself is not significantly slower. https://github.com/iluuu1994/php-src/actions/runs/11859456813/job/33052443092 All in all, it takes 13 instead of 10 minutes, which can be attributed to the VM downloading (maybe we can cache it?) and booting. So, this should be a viable option, and we can probably even keep it for push.

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Christoph! We can proceed with this for now.

@cmb69 cmb69 closed this in 85e23db Nov 15, 2024
@cmb69 cmb69 deleted the cmb/freebsd-13.3 branch November 15, 2024 17:26
@iluuu1994 iluuu1994 mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants