-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FreeBSD CI #16817
Update FreeBSD CI #16817
Conversation
FreeBSD 13.2 is no longer supported[1], and apparently the respective Cirrus CI image has been removed. We update to FreeBSD 13.3. [1] <https://www.freebsd.org/security/#sup> [2] <https://github.com/php/php-src/runs/33044888209>
For context: f2f656c. Apart from removing |
Ah, missed your comment @iluuu1994. Thanks, I'll have a look. We need to cater to 13.3 soon, though, since supports end end of the year. And that will go on. Basically, this is the same issue as with homebrew – we should not rely on rolling releases for security branches. |
@cmb69 Ignoring specific errors works for me too, thanks! |
I agree, but how do we do this in practice? It makes sense to test against the newest version on |
13.2 is going to be EOL. close phpGH-13622 (cherry picked from commit f2f656c)
I think it's best to use LTS whereever possible (except maybe for nightly master); unfortunately, there seems to be no LTS for Homebrew and (Cirrus CI) FreeBSD. |
That's unfortunate... Maybe it's time to finally try QEMU. Running freebsd in nightly (and maybe push with an opt-in flag like |
Cirrus CI runs FreeBSD on amd64, so there shouldn't be the need for QEMU. Still, setting up a FreeBSD might take a long time (a couple of years I had a VirtualBox FreeBSD, and it compiled everything from scratch; don't know if they have binary downloads nowadays). Anyhow, FreeBSD passes now! \o/ |
See ##16119. |
FWIU, QEMU can do virtualization, so there should be no benefit to using something like VirtualBox. I'm trying this now: https://github.com/vmactions/freebsd-vm |
Not a bad idea I use it on one of my projects. It is slow (3mn vs < 5 sec for Linux part) but it can work. |
I understand booting the VM is slow, is compilation & testing itself also slow? |
The difference is less visible but my workload is far lower than php's tough :) you ll see soon enough anyway. |
Indeed 🙂 I can share results in a few hours. |
Some tests fail, which I'll have to look at, but the compilation/testing itself is not significantly slower. https://github.com/iluuu1994/php-src/actions/runs/11859456813/job/33052443092 All in all, it takes 13 instead of 10 minutes, which can be attributed to the VM downloading (maybe we can cache it?) and booting. So, this should be a viable option, and we can probably even keep it for push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Christoph! We can proceed with this for now.
FreeBSD 13.2 is no longer supported[1], and apparently the respective Cirrus CI image has been removed. We update to FreeBSD 13.3.
[1] https://www.freebsd.org/security/#sup
[2] https://github.com/php/php-src/runs/33044888209