-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define default RE2C_FLAGS #14615
Define default RE2C_FLAGS #14615
Conversation
The --no-generation-date flag is a common re2c flag used in all re2c invocations. This adds the 2nd optional argument to PHP_PROG_RE2C M4 macro in BC manner to set the default re2c command-line options and sets the default RE2C_FLAGS similarly on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, even though I m not a lexer expert :)
This flag (--no-genearation-date) only adds the generated date in the top of the file's header comment. Nothing specific to functionality of the generated code here. Other flags are a bit more specific to each file individually otherwise. |
Rechecked and all seems to be working as expected, also that sed command seems to be working from my tests correctly across some exotic shells. Then I think this is ready for merge in the following days. |
I've only appended some CS and help text fixes here. Merge coming up then. This works ok for now. The -g flag is being fixed separately in #11928 because the entire check needs to be refactored a bit further. And it can be also improved on the way in the future as needed. For example, adding |
The --no-generation-date flag is a common re2c flag used in all re2c invocations. This adds the 2nd optional argument to PHP_PROG_RE2C M4 macro in BC manner to set the default re2c command-line options and sets the default RE2C_FLAGS similarly on Windows.