[RFC] Add RFC 3986 and WHATWG compliant URL parsing support #14461
Conversation
| @@ -3715,7 +3715,6 @@ function uniqid(string $prefix = "", bool $more_entropy = false): string {} | |||
|
|
|||
| /** | |||
| * @return int|string|array<string, int|string>|null|false | |||
| * @compile-time-eval | |||
There was a problem hiding this comment.
Removed for benchmarking purposes
ext/url/php_url.c
Outdated
|
|
||
| static void cleanup_parser(void) | ||
| { | ||
| if (++URL_G(urls) % 500 == 0) { |
There was a problem hiding this comment.
Approach is copy-pasted from lexbor/lexbor#206
kocsismate
force-pushed
the
ext-url2
branch
5 times, most recently
from
823e4c6
to
e65deb7
Compare
kocsismate
changed the title
kocsismate
changed the title
kocsismate
force-pushed
the
ext-url2
branch
2 times, most recently
from
0ccffa0
to
04d4e6e
Compare
|
@kocsismate The build failures are not because of Lexbor itself, but because we use a slightly different data structure for the encodings in order to be more memory efficient (see the Note in https://github.com/php/php-src/blob/master/ext/dom/lexbor/patches/README.md) |
|
I need to pull in a new version of Lexbor as well in 8.4 for the GB18030 changes so I'll handle the encoding changes. |
|
@nielsdos Ah thanks for the link! I totally missed the readme :/ TBH I silenced the compiler errors with I was about to report your findings back to my Lexbor issue, but I've just seen that you beat me to do it :) |
I'll make a PR to update Lexbor now, then once that's merged you can rebase on master and get rid of the warning silencer. |
kocsismate
force-pushed
the
ext-url2
branch
3 times, most recently
from
acb1a98
to
5a25f1a
Compare
kocsismate
force-pushed
the
ext-url2
branch
4 times, most recently
from
13e8566
to
8e07430
Compare
2nd take after the failed experiment with #11315
RFC: https://wiki.php.net/rfc/url_parsing_api