Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpseclib, Psalm, PHPStan nightly tests #12270

Closed
wants to merge 42 commits into from

Conversation

danog
Copy link
Contributor

@danog danog commented Sep 22, 2023

Most of the new nightly tests are failing under JIT, ping @dstogov:

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danog!

.github/workflows/nightly.yml Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Show resolved Hide resolved
export ASAN_OPTIONS=exitcode=139
export PHPSECLIB_ALLOW_JIT=1
php /usr/bin/composer install --no-progress --ignore-platform-reqs
php vendor/bin/paratest --verbose --configuration=tests/phpunit.xml --runner=WrapperRunner || exit $?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using paratest for the other frameworks. Can we use it there too? In that case this would be best introduced in a separate PR.

.github/workflows/nightly.yml Outdated Show resolved Hide resolved
@danog
Copy link
Contributor Author

danog commented Oct 10, 2023

Had to reduce the trace count because allocations fails, it turns out JIT was actually disabled after all (??, maybe because my GHA workers have less RAM the the ones used by this org...).

Also submitted #12403 to improve error handling.

@danog danog marked this pull request as ready for review October 10, 2023 15:24
@danog danog requested a review from TimWolla as a code owner October 10, 2023 15:24
@danog
Copy link
Contributor Author

danog commented Oct 10, 2023

Had to reduce the trace count because allocations fails, it turns out JIT was actually disabled after all (??, maybe because my GHA workers have less RAM the the ones used by this org...).

Also submitted #12403 to improve error handling.

@danog danog requested a review from iluuu1994 October 10, 2023 15:24
@danog danog changed the title Add phpseclib, Psalm, PHPStan, UV+AMP nightly tests Add phpseclib, Psalm, PHPStan nightly tests Oct 10, 2023
@danog
Copy link
Contributor Author

danog commented Oct 10, 2023

Closing this in favor of #12406 against PHP-8.1.

@danog danog closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants