Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constants.xml: replace extra spaces #3533

Closed
wants to merge 1 commit into from
Closed

Conversation

mmalferov
Copy link
Member

No description provided.

@Girgias Girgias added the QA Quality Assurance label Jul 26, 2024
@kamil-tekiela
Copy link
Member

Does this make any change? Are any automated checks complaining about this?

@mmalferov
Copy link
Member Author

This only changes how the indents are placed inside the entries. I just asked myself: Would it be better if I replaced the indentation from two spaces with one? And the answer came when I answered myself: To see if it will get better, imagine that you replaced the indentation from two spaces with zero, or three, or eight)) In other files, the indentation of paragraphs or entries is of a single space. I don't find any reason to leave two spaces in the current file unless two spaces are better than one for some reason

@kamil-tekiela
Copy link
Member

Then it's not worth merging this PR. Unless it causes problems, leave it like it is.

@mmalferov mmalferov closed this Oct 8, 2024
@mmalferov mmalferov deleted the patch-6 branch October 8, 2024 01:58
@cmb69
Copy link
Member

cmb69 commented Oct 8, 2024

There are only few style guidelines, and one item is that indentation should be a single space. As such, I think this change is good, but the whole file should be changed. And if we commit with [skip-revcheck], there should be no additional work for translators.

@mmalferov
Copy link
Member Author

In my opinion, the [skip-revcheck] tag is a one-time use. Other translators will still have to do this job when the file changes the next time without the tag, in the future. Only then will the translators have to make both the last change and the accumulated "caring" changes, which are marked with a tag

@cmb69
Copy link
Member

cmb69 commented Oct 8, 2024

To be honest, I've never worked with revcheck. When I was working on the German translation years ago, the docs had been in SVN where you had consecutive revision numbers (much easier to handle). Apparently, revcheck doesn't work as it should, although I don't understand what's the problem exactly. It seems to me that translations who come upon a [skip-revcheck] could just update the EN revision number, and be done.

@Girgias
Copy link
Member

Girgias commented Oct 13, 2024

In my opinion, the [skip-revcheck] tag is a one-time use. Other translators will still have to do this job when the file changes the next time without the tag, in the future. Only then will the translators have to make both the last change and the accumulated "caring" changes, which are marked with a tag

Arguably this is because how we generate the diffs is "naive", possibly already having a diff that ignores whitespace changes might be an improvement. Also using something like difftastic would make for easier diffs to parse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality Assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants