Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the T_PAAMAYIM_NEKUDOTAYIM link text in tokens doc #3508

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

wrossmann
Copy link
Contributor

Original "::" is repetitive and difficult to see.

Changed to "scope resolution" for clarity.

Original "::" is repetitive and difficult to see.

Changed to "scope resolution" for clarity.
@@ -669,7 +669,7 @@ defined('T_FN') || define('T_FN', 10001);
<row xml:id="constant.t-paamayim-nekudotayim">
<entry><constant>T_PAAMAYIM_NEKUDOTAYIM</constant></entry>
<entry>::</entry>
<entry><link linkend="language.oop5.paamayim-nekudotayim">::</link>. Also defined as
<entry><link linkend="language.oop5.paamayim-nekudotayim">scope resolution</link>. Also defined as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep both?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already :: in the syntax column (line above), so I think this change is fine.

@cmb69 cmb69 merged commit 349f6f6 into php:master Oct 8, 2024
2 checks passed
@cmb69
Copy link
Member

cmb69 commented Oct 8, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants