Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing OCI8 constants #3502

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Add missing OCI8 constants #3502

merged 1 commit into from
Jul 7, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jun 28, 2024

No description provided.

@devnexen
Copy link
Member

devnexen commented Jul 6, 2024

hmm considering that oci8 had been unbundled (recently), not sure it s worth the effort. cc @Girgias

@haszi
Copy link
Contributor Author

haszi commented Jul 6, 2024

hmm considering that oci8 had been unbundled (recently),

True but the documentations include a lot of unbundled extension too

not sure it s worth the effort. cc @Girgias

and the effort has been made already. :-)

Girgias
Girgias approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We document everything from PHP 7.0 upwards, so this should be documented.

@Girgias Girgias merged commit aca4a63 into php:master Jul 7, 2024
2 checks passed
@haszi haszi deleted the Add-missing-OCI8-constants branch July 7, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haszi @devnexen @Girgias