Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constants.xml: add constant description #3499

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

mmalferov
Copy link
Member

Can we add a few words about these constants? The socket_getpeername() function page mentions these constants, but there is not a word about them in the documentation

Can we add a few words about these constants? The socket_getpeername() function page mentions these constants, but there is not a word about them in the documentation
@Girgias
Copy link
Member

Girgias commented Jul 7, 2024

Can you rebase the PR?

@mmalferov
Copy link
Member Author

It's done

@Girgias Girgias requested a review from devnexen July 9, 2024 15:06
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Girgias Girgias merged commit cbf8c63 into php:master Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants