Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new $before_needle argument of strrchr() #2719

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Document new $before_needle argument of strrchr() #2719

merged 1 commit into from
Aug 30, 2023

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Aug 29, 2023

Documents the new $before_needle argument of strrchr() add in php/php-src#11430.

Girgias
Girgias approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Girgias Girgias merged commit ac9cbff into php:master Aug 30, 2023
2 checks passed
@Girgias Girgias added this to the PHP 8.3 milestone Aug 30, 2023
@HypeMC HypeMC deleted the add-before-needle-to-strrchr branch August 30, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.3
Development

Successfully merging this pull request may close these issues.
2 participants
@HypeMC @Girgias