Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove personalization (usage of you, we, etc.) #2714

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove personalization (usage of you, we, etc.) #2714

wants to merge 4 commits into from

Conversation

adielcristo
Copy link
Member

@adielcristo adielcristo commented Aug 27, 2023 •
edited
Loading

  • Remove usage of some pronouns (you, we, our, etc.).
  • Add formatting tags (<parameter>, <function>, <literal>, etc.).

Girgias
Girgias reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine but will wait before merging this as this is a QA change.

reference/pdo_sqlite/PDO/sqliteCreateAggregate.xml Outdated Show resolved Hide resolved
reference/pdo_sqlite/PDO/sqliteCreateFunction.xml Outdated Show resolved Hide resolved
@Girgias Girgias added the QA Quality Assurance label Aug 30, 2023
@Girgias Girgias added this to the QA improvements milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

Assignees
No one assigned
Labels
QA Quality Assurance
Projects
None yet
Milestone
QA improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@adielcristo @Girgias