Add mention of is_a() and instanceof in class_implements() and class_parents() pages
#2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Aug 21, 2023
| @@ -99,12 +99,24 @@ Array | |||
| </para> | |||
| </refsect1> | |||
|
|
|||
| <refsect1 role="notes"> | |||
| &reftitle.notes; | |||
| ¬e.no-remote; | |||
There was a problem hiding this comment.
Why this entity?
Doesn't seem related at all and something from a copy/paste.
There was a problem hiding this comment.
I removed it 👍
Comment on lines
107
to
108
| To check that an object implements an interface, you should either use &instanceof; | ||
| or the <function>is_a</function> function. |
There was a problem hiding this comment.
Personalisation:
Suggested change
| To check that an object implements an interface, you should either use &instanceof; | |
| or the <function>is_a</function> function. | |
| To check that an object implements an interface, &instanceof; | |
| or the <function>is_a</function> function should be used instead. |
Girgias
reviewed
Aug 21, 2023
| <refsect1 role="seealso"> | ||
| &reftitle.seealso; | ||
| <para> | ||
| <simplelist> | ||
| <member><function>class_parents</function></member> | ||
| <member><function>get_declared_interfaces</function></member> | ||
| <member><function>is_a</function></member> |
There was a problem hiding this comment.
Instanceof should also be mentionned here
…`class_parents()` pages
alexandre-daubois
force-pushed
the
class_implements_parents_seealso
branch
from
f4a0ac8
to
cd14c1f
Compare
Girgias
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1606