Revert "Fix GH-2635: Fix switch alternative syntax (#2648)" #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the discussion in php#2648, the part that might actually be unexpected is that leading indentation also causes problems. The addition of the empty line distracts from that. Now that the CSS for PHP.net is fixed, this can be reverted. This reverts commit 1d73d6e. see php/web-php#801
TimWolla
commented
Aug 18, 2023
Comment on lines
-73
to
+72
| <?php endswitch; ?> | ||
| <?php endswitch ?> |
There was a problem hiding this comment.
Should the semicolon be preserved here?
There was a problem hiding this comment.
Yeah keep the semicolons, both variants are fine.
There was a problem hiding this comment.
Okay, I've re-added them in #2699 (which I'll immediately merge) to have them in a dedicated commit with a proper message. The “joys” of commit squashing 😔
Girgias
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #2648, the part that might actually be unexpected is that leading indentation also causes problems. The addition of the empty line distracts from that. Now that the CSS for PHP.net is fixed, this can be reverted.
This reverts commit 1d73d6e.
see php/web-php#801