Clarify the output of example code #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing undefined variables generate an E_WARNING since PHP 8 (and will result in error exceptions being thrown in PHP 9).
Girgias
reviewed
Aug 13, 2023
language/variables.xml
Outdated
| @@ -265,7 +265,8 @@ test(); | |||
| </informalexample> | |||
|
|
|||
| <simpara> | |||
| This script will not produce any output because the echo statement | |||
| As of PHP 8, this script will generate an undefined variable warning and will not produce | |||
| any output if the display_errors directive is set to hide warnings, because the echo statement | |||
There was a problem hiding this comment.
While at it could you add a link to the display_error INI setting.
Also, this code would have emitted a notice in PHP 7, they were just not displayed by default.
Girgias
reviewed
Aug 14, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing undefined variables generate an E_WARNING since PHP 8 (and will result in error exceptions being thrown in PHP 9).