Fix GH-2209: update return value and changelog of stream_set_chunk_size() #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Aug 9, 2023
Comment on lines
49
to
51
| Prior to PHP 8.0.0, the function returned &false; if | ||
| <parameter>size</parameter> is less than 1 or greater than | ||
| <constant>PHP_INT_MAX</constant>. |
There was a problem hiding this comment.
I think this (and the same bit in the Error section) should be deleted and moved to the changelog section, with similar phrasing from other changelog entries
There was a problem hiding this comment.
Here you go 🙂
alexandre-daubois
force-pushed
the
stream-set-chunk-size-changelog
branch
from
0768cd9
to
3b13e88
Compare
Girgias
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2209