Clarify array_diff_(u)assoc examples
#2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Aug 7, 2023
| @@ -80,11 +80,13 @@ | |||
| <example> | |||
| <title><function>array_diff_uassoc</function> example</title> | |||
| <para> | |||
| The <literal>"a" => "green"</literal> | |||
| In this example you see the <literal>"a" => "green"</literal> | |||
There was a problem hiding this comment.
Suggested change
| In this example you see the <literal>"a" => "green"</literal> | |
| In this example the <literal>"a" => "green"</literal> |
Would be better to rephrase the other wording to get rid of personalization.
There was a problem hiding this comment.
That's right! I also took the opportunity to remove "you" occurrences in these pages.
alexandre-daubois
force-pushed
the
array-diff-assoc-fix
branch
from
888a3dc
to
fc5dfd7
Compare
Girgias
reviewed
Aug 7, 2023
Comment on lines
97
to
100
| return ($a > $b)? 1:-1; | ||
|
|
||
| return ($a > $b) ? 1 : -1; |
There was a problem hiding this comment.
Could use the spaceship operator, as this exists since 7.0
There was a problem hiding this comment.
Here you go 🙂
alexandre-daubois
force-pushed
the
array-diff-assoc-fix
branch
from
fc5dfd7
to
cd37ecb
Compare
Girgias
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2631
My last try to clarify this wasn't the good fix. I try here to clarify what happens with
array_diff_(u)assocand whyredis present in the output.