Updates the DS interfaces to use new syntax #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2023
|
Just to confirm, does this mean that the docs become buildable using phd's HEAD? |
|
@afilina - yeah, this PR should allow all HEAD tags for PHD/en/src to play nice again. Sorry for the headache there on your PR, this is all kinda my fault when I created a bodge level (in hindsight) interface fix. And then @Girgias found a more proper solution which required some updates that took time - and by then I forgot to follow up with this needed PR. |
Girgias
approved these changes
Aug 3, 2023
|
😊 I had cloned @afilina branch... So my master was never changing to be ahead. I was internally screaming just now as it still wasn't working, but upon debugging my setup; my commit sha was not updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per title, this fixes the current build issues.
this is accomplished by updating the Data Structures docs to match the examples from here: #2563
once merged these interfaces will use the proper new syntax and fixes both the builds and the current render issues on php.net