Update SplFixedArray methods + add PHP 8.2.0 changelog entry
#2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Jul 28, 2023
alexandre-daubois
force-pushed
the
splfixedarray-update
branch
from
f422238
to
32e09ac
Compare
|
Thanks for the tip about |
alexandre-daubois
force-pushed
the
splfixedarray-update
branch
3 times, most recently
from
32e09ac
to
4cb8aaf
Compare
Girgias
reviewed
Jul 28, 2023
kocsismate
reviewed
Jul 28, 2023
reference/spl/splfixedarray.xml
Outdated
| <entry>8.2.0</entry> | ||
| <entry> | ||
| <function>__serialize</function> and <function>__unserialize</function> | ||
| functions are added to <classname>SplFixedArray</classname>. |
There was a problem hiding this comment.
Suggested change
| functions are added to <classname>SplFixedArray</classname>. | |
| magic methods are added to <classname>SplFixedArray</classname>. |
| <refentry xml:id="splfixedarray.unserialize" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <refnamediv> | ||
| <refname>SplFixedArray::__unserialize</refname> | ||
| <refpurpose>Deserializes the <parameter>data</parameter> parameter into a SplFixedArray object</refpurpose> |
There was a problem hiding this comment.
Suggested change
| <refpurpose>Deserializes the <parameter>data</parameter> parameter into a SplFixedArray object</refpurpose> | |
| <refpurpose>Deserializes the <parameter>data</parameter> parameter into an SplFixedArray object</refpurpose> |
There was a problem hiding this comment.
Updated both, thanks for the review!
alexandre-daubois
force-pushed
the
splfixedarray-update
branch
from
3bb96c6
to
e8c554a
Compare
Girgias
reviewed
Jul 31, 2023
reference/spl/splfixedarray.xml
Outdated
Comment on lines
78
to
79
| <function>__serialize</function> and <function>__unserialize</function> | ||
| magic methods are added to <classname>SplFixedArray</classname>. |
There was a problem hiding this comment.
Suggested change
| <function>__serialize</function> and <function>__unserialize</function> | |
| magic methods are added to <classname>SplFixedArray</classname>. | |
| The <methodname>SplFixedArray::__serialize</methodname> and <methodname>SplFixedArray::__unserialize</methodname> | |
| magic methods have been added to <classname>SplFixedArray</classname>. |
Or something along those lines. :)
There was a problem hiding this comment.
Updated, that's better 👍
Girgias
approved these changes
Jul 31, 2023
alexandre-daubois
force-pushed
the
splfixedarray-update
branch
from
e8c554a
to
a391a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1702