Add format RFC 7231 warning #2296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I am not sure if this is wise. The implementation discards the timezone, which isn't quite the same as showing it in GMT. The constant is therefore a little misleading. |
|
I would argue that this patch in php-src is therefore wrong. |
|
Hey @derickr. What do you think about merging this warning and implement fix for the constant later. This way developers are informed until the fix is ready. |
|
I think that the text should indicate that this is currently a known bug, and you should also indent your insertion right (misses an extra space). |
|
@derickr, this is not a bug. This is constant designed specifically this way. I fixed the indentation. |
|
The bug is that the constant just makes it show as it is UTC/GMT without actually adjusting the timezone of the DateTime object that is being formatted.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format RFC 7231 doesn't take into consideration the timezone of the DateTime object. It shows always
GMTdesignation. It should be reflected in documentation.