[PHP 8.0] Document returning a non-array from __sleep() warning. #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://3v4l.org/m1pdW#v8.1rc3 Based on 8.1.0 migration guide, added warning note about __sleep magic method.
salathe
reviewed
Nov 23, 2021
language/oop5/magic.xml
Outdated
| @@ -96,6 +96,11 @@ | |||
| Use <link linkend="object.serialize">__serialize()</link> instead. | |||
| </para> | |||
| </note> | |||
| <note> | |||
| <para> | |||
| As of PHP 8.1.0, returning a value which is not an array from <link linkend="object.sleep">__sleep()</link> generates a diagnostic. | |||
There was a problem hiding this comment.
It looks like earlier versions also generated "a diagnostic" (assuming this means "a diagnostic error", e.g. E_NOTICE, E_WARNING, and friends). I don't see any user-facing change that happened for 8.1.0 (but the level did change from E_NOTICE to E_WARNING in 8.0.0) for this situation.
kocsismate
reviewed
Apr 28, 2022
kocsismate
changed the title
Co-authored-by: Máté Kocsis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://3v4l.org/m1pdW#v8.1rc3
Based on 8.1.0 migration guide, added warning note about __sleep magic method.