Correctly implement the POST credentials method #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenwiltink
force-pushed
the
ec2-credentials
branch
from
74352e5
to
c51346d
Compare
https://docs.openstack.org/api-ref/identity/v3/index.html?expanded=authenticating-with-an-application-credential-detail,create-credential-detail#credentials specifies that the credentials endpoint expects a credential object and returns one. This patch ensures the data is properly encoded and decoded.
k0ka
requested changes
Dec 20, 2023
| @@ -103,4 +103,9 @@ public function listProjects(): \Generator | |||
| { | |||
| return $this->model(Project::class)->enumerate($this->api->getUserProjects(), ['id' => $this->id]); | |||
| } | |||
|
|
|||
| public function listCredentials(): \Generator | |||
There was a problem hiding this comment.
@return \Generator<mixed, \OpenStack\Identity\v3\Models\Credential>
| * Returns a generator which will yield a collection of credential objects. The elements which generators yield can | ||
| * be accessed using a foreach loop. Often the API will not return the full state of the resource in collections; | ||
| * you will need to use retrieve() to pull in the full state of the remote resource from the API. | ||
| */ |
There was a problem hiding this comment.
@return \Generator<mixed, \OpenStack\Identity\v3\Models\Credential>
| @@ -195,6 +195,15 @@ public function userIdQuery(): array | |||
| ]; | |||
| } | |||
|
|
|||
| public function userIdQueryUnderscore(): array | |||
There was a problem hiding this comment.
Why creating new function?
As far as I see https://docs.openstack.org/api-ref/identity/v3/#credentials
POST /v3/credentials and GET /v3/credentials are using the same parameter type user_id.
| @@ -709,6 +710,15 @@ public function getCredentials(): array | |||
| ]; | |||
| } | |||
|
|
|||
| public function getUserCredentials(): array | |||
There was a problem hiding this comment.
There is not need to create a new definition there. We already have getCredentials() and can just reuse it by adding the userId parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.openstack.org/api-ref/identity/v3/index.html?expanded=authenticating-with-an-application-credential-detail,create-credential-detail#credentials
specifies that the credentials endpoint expects a credential object and returns one. This patch ensures the data is properly encoded and decoded.