Merge pull request #6 from michalbundyra/hotfix/double-mock

Allow to mock the same function with defferent arguments in the namespace
php-mock · Dec 11, 2020 · 0dfd45c · 0dfd45c
2 parents 291569e + 748c3d7
commit 0dfd45c
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 7 deletions.
diff --git a/classes/FunctionProphecy.php b/classes/FunctionProphecy.php
@@ -56,10 +56,23 @@ public function __construct($namespace, Prophet $prophet)
      */
     public function __call($functionName, array $arguments)
     {
-        $delegateBuilder = new MockDelegateFunctionBuilder();
-        $delegateBuilder->build($functionName);
-        $prophecy = $this->prophet->prophesize($delegateBuilder->getFullyQualifiedClassName());
-        $this->revelations[] = new Revelation($this->namespace, $functionName, $prophecy);
+        foreach ($this->revelations as $revelation) {
+            if (
+                $revelation->namespace === $this->namespace
+                && $revelation->functionName === $functionName
+            ) {
+                $prophecy = $revelation->prophecy;
+                break;
+            }
+        }
+
+        if (! isset($prophecy)) {
+            $delegateBuilder = new MockDelegateFunctionBuilder();
+            $delegateBuilder->build($functionName);
+            $prophecy = $this->prophet->prophesize($delegateBuilder->getFullyQualifiedClassName());
+            $this->revelations[] = new Revelation($this->namespace, $functionName, $prophecy);
+        }
+
         return $prophecy->__call(MockDelegateFunctionBuilder::METHOD, $arguments);
     }
 

diff --git a/classes/Revelation.php b/classes/Revelation.php
@@ -18,19 +18,22 @@ final class Revelation implements ProphecyInterface
 {
 
     /**
+     * @internal
      * @var string The function namespace.
      */
-    private $namespace;
+    public $namespace;
 
     /**
+     * @internal
      * @var string The function name.
      */
-    private $functionName;
+    public $functionName;
 
     /**
+     * @internal
      * @var ProphecyInterface The prophecy.
      */
-    private $prophecy;
+    public $prophecy;
 
     /**
      * Builds the revelation.

diff --git a/tests/PHPProphetTest.php b/tests/PHPProphetTest.php
@@ -47,6 +47,28 @@ protected function defineFunction($namespace, $functionName)
         PHPProphet::define($namespace, $functionName);
     }
 
+    public function testDoubleMockTheSameFunctionWithDifferentArguments()
+    {
+        $prophecy = $this->prophet->prophesize(__NAMESPACE__);
+        $prophecy->min(1, 10)->willReturn(0);
+        $prophecy->min(20, 30)->willReturn(1);
+        $prophecy->reveal();
+
+        $this->assertSame(0, min(1, 10));
+        $this->assertSame(1, min(20, 30));
+    }
+
+    public function testTwoDifferentFunctionsMock()
+    {
+        $prophecy = $this->prophet->prophesize(__NAMESPACE__);
+        $prophecy->min(1, 10)->willReturn(0);
+        $prophecy->max(20, 30)->willReturn(1);
+        $prophecy->reveal();
+
+        $this->assertSame(0, min(1, 10));
+        $this->assertSame(1, max(20, 30));
+    }
+
     /**
      * This test is skipped until PHPUnit#2016 is resolved.
      *