Supporting protobuf message support #1329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
Dec 22, 2023
|
LGTM, though ci is red |
ahmedkhan847
force-pushed
the
protobuf_support
branch
from
c6d9e15
to
ba5fd89
Compare
|
These 2 specs |
|
@makasim The one which are failed are not because of my changes. Can we re-run them or merge this PR? |
|
I cannot merge failing CI it should be green. |
|
I know but can you re-run those? Because all the other same version specs are passing :) plus they are 'gpqm' related specs. |
@ahmedkhan847 I can help look later to see if we figure out something for the failed tests. |
|
@makasim Can you rerun it I have fixed the tests for |
|
@makasim the issue was the docker image tag for localstack. I have updated the docker image tag to the previous then latest version in docker-compose file and now all the specs are passing on my local. I couldn't find how your ci if it is using the docker-compose file it will automatically pick it and should work. |
|
@makasim this is the log of specs from my local |
|
@makasim Can you please review it? |
|
@makasim fix the issue in the waitfor part. I hope it works this time :) Sorry it taking a lot of your time as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the serializer in my current project, I was unable to get messages in protobuf format. So instead encoding/decoding every message from JSON we can send the actual message as it is so that it can be serialized into the appropriate class for that message. Protobuf PHP provides the methods:
$message->fromString()and$message->fromJson()which can bind the data to your class. Also added attributes as properties of the message.