Add test profile for FFXIV Endwalker Benchmark #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotarou3
commented
Oct 16, 2022
| This test calculates the score from the FFXIV Endwalker Benchmark, released in 2021. | ||
|
|
||
| Technically a Windows-only benchmark, but also runs at near-native performance under Linux with wine+dxvk (e.g., with the USE_WINE config)</Description> | ||
| <ResultScale>Score</ResultScale> |
There was a problem hiding this comment.
The benchmark outputs two results: A score, and an average FPS value.
I'm not sure which one is more appropriate here.
The benchmark considers the score the "main" result, but I personally think the average FPS is a more practical result
kotarou3
commented
Oct 16, 2022
| <ResultsParser> | ||
| <ResultScale>Frames Per Second</ResultScale> | ||
| <ResultProportion>HIB</ResultProportion> | ||
| <OutputTemplate>SCORE_FPSAVERAGE=#_RESULT_#</OutputTemplate> |
There was a problem hiding this comment.
The benchmark also produces a list of per-second FPS values looking like this:
KEYS_COUNT=373
K0=33
K1=31
K2=31
...
K370=71
K371=72
K372=72Is there any way for PTS to capture this info as well? (e.g., for min or 5th percentile FPS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related feature request: https://www.phoronix.com/forums/forum/phoronix/phoronix-test-suite/1335849-creating-a-test-profile-for-final-fantasy-xiv-endwalker-benchmark
I'm still doing a final bit of testing on whether this needs the "skip first run" option or not, so don't merge this PR just yet.
I'm sending out this PR early so I can get feedback on any changes if needed.
There are also other "editions" of the benchmark available that I might add in the future. But I'm not sure if they should be added as different versions or completely different profiles: