Close statements when finished, preventing statement leak

phoreproject · Mar 13, 2018 · 53bbb0e · 53bbb0e
1 parent 919354d
commit 53bbb0e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/apiserver/index.js b/apiserver/index.js
@@ -16,7 +16,7 @@ app.get("/logo.png", (req, res) => {
 const config = require('./config')
 
 app.get("/", (req, res) => {
- res.send()
+ res.send(config)
 })
 
 app.get('/search/listings', (req, res) => {

diff --git a/db/mysql.go b/db/mysql.go
@@ -49,6 +49,7 @@ func (d *SQLDatastore) SaveNodeUninitialized(n crawling.Node) error {
  if err != nil {
  return err
  }
+ defer insertStatement.Close()
 
  _, err = tx.Stmt(insertStatement).Exec(n.ID)
  if err != nil {
@@ -69,6 +70,7 @@ func (d *SQLDatastore) SaveNode(n crawling.Node) error {
  if err != nil {
  return err
  }
+ defer insertStatement.Close()
 
  _, err = tx.Stmt(insertStatement).Exec(
  n.ID,
@@ -120,6 +122,7 @@ func (d *SQLDatastore) AddUninitializedNodes(nodes []crawling.Node) error {
  if err != nil {
  return err
  }
+ defer insertStatement.Close()
 
  _, err = tx.Stmt(insertStatement).Exec(nodes[n].ID)
  if err != nil {
@@ -136,6 +139,7 @@ func (d *SQLDatastore) GetNode(nodeID string) (*crawling.Node, error) {
  if err != nil {
  return nil, err
  }
+ defer s.Close()
  r := s.QueryRow(nodeID)
  node := &crawling.Node{}
  err = r.Scan(&node.ID, &node.LastCrawled)
@@ -157,6 +161,7 @@ func (d *SQLDatastore) AddItemsForNode(owner string, items []crawling.Item) erro
  if err != nil {
  return err
  }
+ defer s.Close()
 
  _, err = s.Exec(owner)
  if err != nil {
@@ -168,6 +173,7 @@ func (d *SQLDatastore) AddItemsForNode(owner string, items []crawling.Item) erro
  if err != nil {
  return err
  }
+ defer s.Close()
 
  _, err = s.Exec(
  owner,

diff --git a/main.go b/main.go
@@ -18,7 +18,7 @@ func main() {
  rpcURL := flag.String("rpc", "127.0.0.1:5002", "rpc url used to connect to Phore Marketplace")
  flag.Parse()
 
- database, err := sql.Open("mysql", *databaseURL+"?parseTime=true")
+ database, err := sql.Open("mysql", *databaseURL+"?parseTime=true&interpolateParams=true")
  if err != nil {
  panic(err)
  }