More updates from Pivx Upstream #177
Open
+42,328
−19,849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bad068a)
There were surprisingly many `#ifdef` fallbacks for Qt 4. Removing them simplifies maintenance, as well as adding new GUI functionality. (cherry picked from commit 907f73b)
Fix an edge case where autocombine would get stuck if available UTXOs are low in value compared to autocombine threshold
This file has not been used in quite a while, nuke it from orbit.
Prevent file access collisions and possible file corruption by refusing to overwrite the current wallet in use.
(cherry picked from commit 908c1d7)
This function is never used, and never will be; Nuke it from orbit.
verifychain only accepts a single (optional) argument instead of two, and we need to capture that argument properly.
Properly return an error when attempting to use a negative timeout. Also sanitize the timeout so as to not cause a value error with libevent on MacOS.
Even though this command is all but deprecated, it's help output and example were incorrect and deserving of an update. amount is the 3rd paramater, and is required. minconf is the 4th paramater, and for all intents and purposes is a "dummy" paramater since it is no longer considered in the functional logic.
When calling `getreceivedbyaddress` with a non-wallet address, return a proper error code/message instead of `0`
check-doc and logprint-scanner were still using python2 conventions. This updates the two scripts to use pyhon3 instead and be consistent with the rest of our python utility scripts. Also, use a more widely accessible bash path in lint-whitespace.sh
Used primarialy (for now) in node identification for upcoming regtest scripting.
Simple addition to the JSON output; mainly used in upcoming functional test updates.
Simple consistency addition. This mimmics the output from `getinfo`.
- Fix git's rev-list call - Add proper copyright headers from upstream - Check that the script is in the git tree
This moves CScheduler and threadGroup to a static declaration in init .cpp so as to avoid a potential shutdown deadlock where both are freed before the network message handler thread has been completely released.
…emove vchDefaultKey and have better first run detection". [Wallet][Startup][DB][Backport] Don't create any default address
Move the two CMake build tests further up in the test order so we don't have to manually restart them due to caching/timeouts.
to check balances in a reorganization of PoS blocks, and verify that the input of an orphan block's coinstake is spendable after.
…mpool check code cleanup in IsTrusted method. Comes from bitcoin b2b3619
- qualify as constants the arguments of CWallet's functions: IsLockedCoin, LockCoin and UnlockCoin. - Diagnose unsuitable outputs in lockunspent (backports bitcoin/bitcoin bitcoin#11087)
… the tip, preventing possible multi-threading shared resource problem. Remove duplicated tip check.
When the build number (CLIENT_VERSION_BUILD) is non-zero, we want to include that in the package version number so the resulting binaries are named with the correct version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.