Updates from Pivx Upstream #174

KolbyML · 2020-03-14T16:42:26Z

No description provided.

Another removal of boost dependency as well as fixing up some `-Wthread-safety-analysis` issues.

Code to avoid calling Perfmon too often is only needed when perfmon is actually going to get called. This is not intended to make any functional difference in the addition of entropy to the random pool.

No need to define it for every CAddress, as it's memory only anyway.

[Refactoring] Moved and removed some stuff -Removed duplicated arith uint files -Removed unused variables -Move keystore impls to .cpp instead of .h -Removed useless function in key.cpp [Crypto] fix bip38 compilation for latest libsecp256k1 [Compilation] Change compilation and some code to use libsec instead of sslcrypto [Crypto] Update keys to comply with latest secp256k1 lib

With C++11 these functions are not needed anymore and gracefully replaced

The zerocoin database should be wiped on reindex. If leftover information from a fork is left in the db it can lead to potential validation issues in the future and isolated forks.

rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read.

Custom boost locations not using pkg_config can result in a header include not being found when compiling the libzerocoin library. This quick fix ensures that the `BOOST_CPPFLAGS` are explicitely included.

Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise.

Instead of using boost::lexical_cast we can just use std::to_string

Use proper include ordering and only include the needed QStyle header.

Also use proper define in header file

caea417 Update QT to 5.9.7 (cevap) Tree-SHA512: 34197e7b92711f3f0392b071de58900592ab8bb2ed3e50cd853cf2da56ba2f6d9b3ee57e4d01f3c2cdce4710ebe0c079bba434263b9af65141363086b9213025

…ith gitian f6c1d4a Add check symbols for gitian-linux.yml (cevap) 4a3d3ea Use pivx in config lines (cevap) 321f0e0 Update linux descriptor (cevap) 4e0244b Update symbol check script (cevap) c251de5 Update glibc_compat.cpp with risc (cevap) fb0bdae Gitian: add risc build (cevap) Tree-SHA512: f91fa1da9c48e3ccb87cb1ddd825d353a15e439b778bd95eb53f22b8884ecb1ddda954a506553dbb8322e931d1b8b34211e1dc7e4b431eafa107d81bdd8e6faa

Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6250 Signed-off-by: cevap <[email protected]>

Github-Pull: PIVX-Project#858 Rebased-From: 21f5078

Break out a new job to do the basic linting that check-dock.py and logprint-scanner.py did. Also add new scripts to check the sanity of any git subtrees and to check that new pull requests don't contain any trailing whitespace. Also, remove the outdated slack notification callback

Also for libsecp256k1 now that it has been updated

This changes the TravisCI behavior to use docker with a Bionic target. Provides consistency with gitian target.

…56k1'

…update

wqking · 2021-09-05T08:33:27Z

Hi Kolby, did you build this version on Linux?
When I try to build it on Ubuntu, I get this error,

  CXXLD    phored
/usr/bin/ld: libzerocoin/libbitcoin_zerocoin.a(Accumulator.o): relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a shared object; recompile with -fPIC
libzerocoin/libbitcoin_zerocoin.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
Makefile:3707: recipe for target 'phored' failed
make[2]: *** [phored] Error 1

I tried to add -fPIC to configure.ac, but still get this error.
Did you see such error?

PR #174 conflictions fix

Fuzzbawls and others added 6 commits March 7, 2020 12:24

Miner: use std methods instead of boost for timing conditions

b81eb56

Remove Boost dependency from the httpserver

d36dbc8

Ust std threading in sync.{h,cpp}

cdf4e2a

Another removal of boost dependency as well as fixing up some `-Wthread-safety-analysis` issues.

[RPC] Show BIP65 soft-fork progress in getblockchaininfo

44f8161

WIN32 Seed Cleanup: Move nLastPerfmon behind win32 ifdef.

bd068e5

Code to avoid calling Perfmon too often is only needed when perfmon is actually going to get called. This is not intended to make any functional difference in the addition of entropy to the random pool.

nLastTry is only used for addrman entries

8d24bcb

No need to define it for every CAddress, as it's memory only anyway.

KolbyML closed this Mar 14, 2020

KolbyML reopened this Mar 14, 2020

Warrows and others added 22 commits March 14, 2020 17:16

[Tests] Add new auto generated script tests

002aef4

[Crypto] Bring back function CKey.SetPrivKey for zPIV

3bbebe8

[Crypto] Add ctx initialisation for bip38

7a63c62

[Refactor] Remove begin/end_ptr functions

8e304df

With C++11 these functions are not needed anymore and gracefully replaced

Wipe zerocoin DB on reindex.

ffb4d90

The zerocoin database should be wiped on reindex. If leftover information from a fork is left in the db it can lead to potential validation issues in the future and isolated forks.

[Bug] Fix CMasternodeConfig::read

a819103

rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read.

use c++11 for instead of boost for mnconf count

670ae61

[GUI] Fix wrongly displayed balance on Overview tab

ad21d7b

[Build] Remove unnecessary BOOST dependency

1a9ae7c

Check whether tx is in chain in ContextualCheckZerocoinMint().

fbf04f6

[Build] Make sure Boost headers are included for libzerocoin

9b9ad39

Custom boost locations not using pkg_config can result in a header include not being found when compiling the libzerocoin library. This quick fix ensures that the `BOOST_CPPFLAGS` are explicitely included.

[Qt] Add Tor service icon to status bar

739e6e4

Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise.

[UI] Remove useless help button from QT dialogs

0d6514c

Move non-wallet RPC files to subdir

538fab9

Remove unnecessary namespace declarations

c6ee535

Remove boost dependency

f5dcf5a

Instead of using boost::lexical_cast we can just use std::to_string

Clean up header includes

f779b29

Use proper include ordering and only include the needed QStyle header.

Add proper translation functions for user facing strings

6821991

Remove useless returns

7811144

Comment/Whitespace/nullptr cleanup

134eacd

Also use proper define in header file

fix double locked coin when wallet and MN are on same machine

61d6ac9

Fuzzbawls and others added 25 commits March 14, 2020 17:22

Gitian: update descriptors for bionic

db850e5

Contrib: Update macdeployqtplus subdir

8b36eb1

Update packages.mk

4e55e6a

Update protobuf.mk

386a52b

fixes for changes

f78dada

Merge PIVX-Project#783: [Depends] Update QT to 5.9.7

c72627f

caea417 Update QT to 5.9.7 (cevap) Tree-SHA512: 34197e7b92711f3f0392b071de58900592ab8bb2ed3e50cd853cf2da56ba2f6d9b3ee57e4d01f3c2cdce4710ebe0c079bba434263b9af65141363086b9213025

Fix Missing Explorer Icon

75f2c3b

Update qt.mk

f84aadd

Improve addrman Select() performance when buckets are nearly empty

61be3a4

Update zmq to 4.3.1

3a09580

Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6250 Signed-off-by: cevap <[email protected]>

cleanup, remove trading dialog form

7922e3c

fix to display missing clock5.png tx image

5663208

[macOS] Remove DS_Store WindowBounds bytes object

4bb73fe

Github-Pull: PIVX-Project#858 Rebased-From: 21f5078

Fixed some names in a few files

e5d8cb7

travis: run subtree checks for leveldb

ffc0a86

Also for libsecp256k1 now that it has been updated

Travis: Update to use docker with Bionic target

02bbc02

This changes the TravisCI behavior to use docker with a Bionic target. Provides consistency with gitian target.

Travis: Introduce .travis subdir and better job folding

07eb90f

Update .travis.yml

f93e697

[Refactor] Delete secp256k1 folder for subtreefication

ae8b73b

Merge commit '8a901f93d505af3516353837600fd71a0c53a692' as 'src/secp2…

f8de61b

…56k1'

Merge commit 'c6634ef065ceb295522f0d61a3d45d8d53abe51c' into libsecp_…

e55c1df

…update

Merge commit '4f5b53da1af363a5c41acc8e1d82f37dd7f393d9' as 'src/leveldb'

da72b62

fixes for leveldb and travis

043e609

tohsnoom changed the base branch from master to rel-1.7.0 November 16, 2020 01:54

tohsnoom changed the base branch from rel-1.7.0 to release-1.8.0 January 18, 2021 22:43

wqking mentioned this pull request Sep 29, 2021

PR #174 conflictions fix #193

Merged

tohsnoom added a commit that referenced this pull request Oct 18, 2021

Merge pull request #193 from wqking/pr-174-fix-conflicts

57bdf28

PR #174 conflictions fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates from Pivx Upstream #174

Updates from Pivx Upstream #174

KolbyML commented Mar 14, 2020

wqking commented Sep 5, 2021

Updates from Pivx Upstream #174

Are you sure you want to change the base?

Updates from Pivx Upstream #174

Conversation

KolbyML commented Mar 14, 2020

wqking commented Sep 5, 2021