This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Clear inbox messages list when clicking action button #2705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, clicking an action button with foreground=false doesn't clear the list of messages of an inbox notification, the only thing it does is dismiss the notification. If you receive a new notification, the full list is displayed again.
With this patch the list is cleared when an action button is clicked. This affects inline replies too.
Related Issue
#2699
Motivation and Context
The list of messages should be cleared when clicking an action button, otherwise the user will see the same notifications over and over again.
How Has This Been Tested?
I didn't find any Jasmine test about inbox notifications, so I tested it manually in:
The changes are quite small and shouldn't affect other areas of the code.
Types of changes
Checklist: