Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at basic contribution and submission guidelines #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

filmaj
Copy link
Collaborator

@filmaj filmaj commented Dec 6, 2016

Went with a pull-request template as a submission guideline / checklist, basically. Based it mostly off of @jahoni's google-doc-based submission review list.

This is an attempt at solving issue #7.

It also relates to phonegap/phonegap.github.io#30.

Let me know what y'all think, cc @jahoni @GarthDB @jenlgray.

@jahoni
Copy link
Collaborator

jahoni commented Dec 6, 2016

These are definitely the guidelines for our own decision criteria, but I think we might be missing some key info -- the assets and info are we requesting people submit.

Deriving from the mock-up (shown below), we're looking for these data points:

  • App icon (what size, what format?)
  • App name
  • App creator (name?)
  • App creator website
  • App description (max length?)
  • Screenshots (what size, what format?)
  • App store links

appshowcase-appdetail

@filmaj
Copy link
Collaborator Author

filmaj commented Dec 7, 2016

I think this is pretty good as a starting point. Good to merge?

@jahoni
Copy link
Collaborator

jahoni commented Dec 7, 2016

I'm good with it - do either @jenlgray or @GarthDB have an opinion?

once it is live, it'd be cool to get the ability to submit added to the website: phonegap/phonegap.github.io#175

@GarthDB
Copy link
Collaborator

GarthDB commented Dec 7, 2016

I think this is great - there's still some manual work if they file an issue, but it's better to capture this information manually than to let it fall through the cracks.

Thanks @filmaj and @jahoni. I'll have @jenlgray double check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants