Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #354 (enabledRemoteNotificationTypes is not supported in iOS 8... #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rossmartin
Copy link

This commit fixes issue #354 (enabledRemoteNotificationTypes is not supported in iOS 8.0 and later).

I have confirmed this works in iOS 7 and 8.

@dbaq
Copy link

dbaq commented Feb 12, 2015

@rossmartin have you tried this with cordova 4.x?

@rossmartin
Copy link
Author

@dbaq It works for me with the latest version of Cordova for iOS v3.7.0

I am using the Cordova CLI v4.2.0

@eladmoshe
Copy link

@rossmartin You are awesome, thanks!
Please merge this ASAP, the plugin is currently broken! :(

@CedNet
Copy link

CedNet commented Feb 17, 2015

Upvote here to merge. Please.

@fujifish
Copy link

+1 !!!

@dortzur
Copy link

dortzur commented Feb 17, 2015

+1
Would have saved me a lot of grief today.

@ycarmel
Copy link

ycarmel commented Feb 17, 2015

+1

@Strate
Copy link

Strate commented Mar 6, 2015

Upvote!

@molaschi
Copy link

+1

@robbieboyd-io
Copy link

Did this fix happen?

@alloyking
Copy link

robbieboyd-io, wondering the same thing. I still have the error.

@jdtaylor91
Copy link

+1
Could this fix please be merged

@samuelgoldenbaum
Copy link

+1

@thkus
Copy link

thkus commented May 26, 2015

Hi there, it seems a Fix for that is in master, isn't it?
Check: https://github.com/phonegap-build/PushPlugin/blob/master/src/ios/PushPlugin.m Line 121

I just needed to update my dependencies and it's working.

@EeKay
Copy link

EeKay commented May 28, 2015

@Tosse: that is a fix in the master indeed, but it's not complete... @rossmartin's codechange fixes the second instance where enabledRemoteNotificationTypes is being called for <iOS 8.0 devices..

+1 to merge that puppy and get going !

@dexterity42
Copy link

+1

@ohh2ahh
Copy link

ohh2ahh commented Jun 29, 2015

Thanks, it works perfectly with Cordova CLI 5.1.1 and Cordova iOS platform 3.8.0 on a iOS 8.3 device. Please merge.

@TheMattRay
Copy link

+1

@SimonRiis
Copy link

+1 Getting this error using the master

@schoettler
Copy link

Got this issue on the master branch, fixed with this fork

+1 merge

@bender-2000
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.