Use to_form :action as changeset action when passed #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
|
Note this will require changing the mix.exs entry to: Assuming we are launching phoenix_html v4.1. |
SteffenDE
reviewed
Feb 6, 2024
lib/phoenix_ecto/html.ex
Outdated
| {action, changeset} = | ||
| case Keyword.fetch(opts, :action) do | ||
| {:ok, action} -> {action, Map.put(changeset, :action, action)} | ||
| :error -> {nil, changeset} |
There was a problem hiding this comment.
Suggested change
| :error -> {nil, changeset} | |
| :error -> {changeset.action, changeset} |
josevalim
reviewed
Feb 6, 2024
lib/phoenix_ecto/html.ex
Outdated
Comment on lines
4
to
8
| {action, changeset} = | ||
| case Keyword.fetch(opts, :action) do | ||
| {:ok, action} -> {action, Map.put(changeset, :action, action)} | ||
| :error -> {nil, changeset} | ||
| end |
There was a problem hiding this comment.
Suggested change
| {action, changeset} = | |
| case Keyword.fetch(opts, :action) do | |
| {:ok, action} -> {action, Map.put(changeset, :action, action)} | |
| :error -> {nil, changeset} | |
| end | |
| {action, opts} = Keyword.pop_lazy(opts, :action, fn -> changeset.action end) |
josevalim
reviewed
Feb 6, 2024
lib/phoenix_ecto/html.ex
Outdated
| @@ -11,6 +17,7 @@ if Code.ensure_loaded?(Phoenix.HTML) do | |||
| source: changeset, | |||
| impl: __MODULE__, | |||
| id: id, | |||
| action: action, | |||
| name: name, | |||
| errors: form_for_errors(changeset), | |||
There was a problem hiding this comment.
Suggested change
| errors: form_for_errors(changeset), | |
| errors: form_for_errors(action, changeset), |
josevalim
reviewed
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:
phoenixframework/phoenix_html#439
phoenixframework/phoenix_live_view#3090
phoenixframework/phoenix#5713