Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve parameter filtering performance #957

Draft
wants to merge 1 commit into
base: release-2.5
Choose a base branch
from
Draft

improve parameter filtering performance #957

wants to merge 1 commit into from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 8, 2024

This is currently just reviving an old experimental branch to try to flip the loops within parameter filtering to loop over parameters in the outer loop and filtering kwargs in the inner-loop.

TODO:

  • revisit to see if there are any better designs
  • fix any failing tests
  • profile to see if this does perform better
  • address inline comments
  • add any missing test coverage

@kecnry
revive experimental code to rewrite filtering logic
8cea7d7 
to loop through parameters in outer loop instead of kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kecnry