Adds fallbacks for resource title display #515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #462, where we want to improve the display the resource title/subtitle(s) when there is missing data.
Notes for reviewers:
Verification
Given four resources, if we assume that lat/long is always present, then there are four possible combinations for available data. Below are examples from the data of each, and screenshots of how they are currently being handled with this PR.
Examples with lat, long provided
Examples - screenshots and all the resource details
name, address, and lat/long present
name and lat/long only
address and lat/long only
lat/long only
Note that the lat/long only example does not have a screenshot since the pin does not appear to be on the map. This may be a bug and/or need to be handled with some additional code.
attn: @lxh5395, @tomporvaz, @vontell