Hotfix for broken selector import #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vontell
requested changes
Aug 1, 2024
gcardonag
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Approved, this will fix the issue breaking the latest builds in the develop branch. Thanks @ravicodelabs !
|
Going to merge this since the requested changes have already been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a broken import which is causing the app not to run in a local (docker) development environment (though notably, the app is still working at beta.phlask.me,
so perhaps there is a difference elsewhere, such as in the production build/server approach, I think the beta.phlask.me app may be falling back to the last successful build). This PR fixes that import and allows the app to start normally in a local development environment again.