Get Filters Working #475
Merged
Get Filters Working #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tayloraj10! Is this ready to review? Just wanted to confirm the state of this PR before jumping in |
@vontell yeah this is ready for review |
vontell
requested changes
Jul 30, 2024
vontell
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Change Summary
Summary of changes made. This can be a paragraph, list of bullet points, etc. Aim to be brief and concise.
Change Reason
Summary of why changes are being made. Link to other documents, Slack conversations, etc are good to post here for explaining the reason for particular changes.
Verification [Optional]
A .gif, video, or screenshots of the feature are extremely helpful in verifying that code changes are working correctly. Feel free to include them in the PR to help the reviewer.
We recommend using OBS to record videos, as it is open source, free, and available on all major operating systems.
Related Issue: #<Github Issue Number (if one exists)>