Skip to content

Commit

Permalink
Merge branch 'develop' into remove-tutorial
Browse files Browse the repository at this point in the history
  • Loading branch information
gcardonag authored Aug 7, 2024
2 parents 50e56cb + 7ff0aaf commit f51ebd7
Show file tree
Hide file tree
Showing 19 changed files with 302 additions and 425 deletions.
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ build/

# Unused files
Legend.js
TypeToggle.js
6 changes: 3 additions & 3 deletions cypress/e2e/desktop/siteInfo.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ describe('site info', () => {

it('should successfully display a food site', () => {
// Switch to food view
cy.get('[data-cy=button-resource-type-menu]').click();
cy.get('[data-cy=button-food-data-selector').click();
cy.get('[data-cy=button-resource-type-menu]').click();
cy.get('[data-cy=button-resource-type-menu]').click()
cy.get('[data-cy=button-FOOD-data-selector]').click()
cy.get('[data-cy=button-resource-type-menu]').click()

// Load a sample food site
// This is currently using live data, but should be updated to make use of test data.
Expand Down
13 changes: 2 additions & 11 deletions src/actions/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ export const setMapCenter = coords => ({
type: SET_MAP_CENTER,
coords
});
export const toggleInfoWindow = createAction('TOGGLE_INFO_WINDOW');

export const TOGGLE_INFO_WINDOW_CLASS = 'TOGGLE_INFO_WINDOW_CLASS';
export const toggleInfoWindow = createAction('TOGGLE_INFO_WINDOW');
export const toggleInfoWindowClass = createAction('TOGGLE_INFO_WINDOW_CLASS');

export const TOGGLE_INFO_EXPANDED = 'TOGGLE_INFO_EXPANDED';
Expand Down Expand Up @@ -103,12 +102,4 @@ export const TOOLBAR_MODAL_FILTER = 'TOOLBAR_MODAL_FILTER';
export const TOOLBAR_MODAL_SEARCH = 'TOOLBAR_MODAL_SEARCH';
export const TOOLBAR_MODAL_CONTRIBUTE = 'TOOLBAR_MODAL_CONTRIBUTE';

export const toggleResourceType = createAction('TOGGLE_RESOURCE_TYPE');

export const toggleResourceMenu = createAction('TOGGLE_RESOURCE_MENU');

export const CHANGE_RESOURCE_TYPE = 'CHANGE_RESOURCE_TYPE';
export const changeResourceType = resourceType => ({
type: CHANGE_RESOURCE_TYPE,
resourceType
});
export const setResourceType = createAction('SET_RESOURCE_TYPE');
40 changes: 20 additions & 20 deletions src/components/AddResourceModal/useOnClickOutside.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import { useEffect } from "react";

const useOnClickOutside = (ref, callback) => {
useEffect(() => {
const listener = (event) => {
if (!ref.current || ref.current.contains(event.target)) {
return;
}
callback(event);
};
document.addEventListener('mousedown', listener);
document.addEventListener('touchstart', listener);
return () => {
document.removeEventListener('mousedown', listener);
document.removeEventListener('touchstart', listener);
};
}, [ref, callback]);
};
export default useOnClickOutside;
useEffect(() => {
const listener = (event) => {
if (!ref.current || ref.current.contains(event.target)) {
return;
}

callback(event);
};

document.addEventListener('mousedown', listener);
document.addEventListener('touchstart', listener);

return () => {
document.removeEventListener('mousedown', listener);
document.removeEventListener('touchstart', listener);
};
}, [ref, callback]);
};

export default useOnClickOutside;
154 changes: 0 additions & 154 deletions src/components/ChooseResource/ChooseResource.js

This file was deleted.

63 changes: 63 additions & 0 deletions src/components/ChooseResourceType/ChooseResourceType.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
import useIsMobile from 'hooks/useIsMobile';
import DesktopChooseResourceType from './DesktopChooseResourceType';
import MobileChooseResourceType from './MobileChooseResourceType';
import { ReactComponent as DesktopBathroomIcon } from '../icons/BathroomIconChooseResource.svg';
import { ReactComponent as DesktopFoodIcon } from '../icons/FoodIconChooseResource.svg';
import { ReactComponent as DesktopForagingIcon } from '../icons/ForagingIconChooseResource.svg';
import { ReactComponent as DesktopWaterIcon } from '../icons/WaterIconChooseResource.svg';
import { ReactComponent as MobileWaterIcon } from '../icons/WaterIconV2.svg';
import { ReactComponent as MobileFoodIcon } from '../icons/FoodIconV2.svg';
import { ReactComponent as MobileForagingIcon } from '../icons/ForagingIconV2.svg';
import { ReactComponent as MobileBathroomIcon } from '../icons/ToiletIconV2.svg';
import {
WATER_RESOURCE_TYPE,
FOOD_RESOURCE_TYPE,
FORAGE_RESOURCE_TYPE,
BATHROOM_RESOURCE_TYPE
} from '../../types/ResourceEntry';

const resourceTypeInfo = [
{
type: WATER_RESOURCE_TYPE,
textLabel: 'Water',
color: "#5286E9",
desktopIcon: DesktopWaterIcon,
mobileIcon: MobileWaterIcon,
},
{
type: FOOD_RESOURCE_TYPE,
textLabel: 'Food',
color: "#FF9A55",
desktopIcon: DesktopFoodIcon,
mobileIcon: MobileFoodIcon,
},
{
type: FORAGE_RESOURCE_TYPE,
textLabel: 'Foraging',
color: "#5DA694",
desktopIcon: DesktopForagingIcon,
mobileIcon: MobileForagingIcon,
},
{
type: BATHROOM_RESOURCE_TYPE,
textLabel: 'Bathroom',
color: "#9E9E9E",
desktopIcon: DesktopBathroomIcon,
mobileIcon: MobileBathroomIcon,
}
]

const ChooseResourceType = () => {

const isMobile = useIsMobile();

return (
<>{!isMobile ?
<DesktopChooseResourceType resourceTypeInfo={resourceTypeInfo} />
:
<MobileChooseResourceType resourceTypeInfo={resourceTypeInfo} />}
</>
);
};

export default ChooseResourceType;
Loading

0 comments on commit f51ebd7

Please sign in to comment.