feat(runner): support Ubuntu 24.04 #4246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgp1701
approved these changes
Nov 8, 2024
bdellegrazie
force-pushed
the
fix/ubuntu-24.04
branch
from
823afb9
to
7dcef0f
Compare
|
Additional change to the user data template to make the Ubuntu example work. |
npalm
changed the title
npalm
reviewed
Nov 15, 2024
npalm
reviewed
Nov 15, 2024
npalm
reviewed
Nov 15, 2024
npalm
reviewed
Nov 15, 2024
There was a problem hiding this comment.
@bdellegrazie great to see support for ubuntu 24.04 is coming in. What is the status of the PR? How did you test the PR. Is the cahnge working as well for ubuntu 22.04
|
Just testing the setup on ubuntu 22.04, works all fine. Still curious if there are any side effects. Are you also aware we thinking about update the module to support ubuntu by default, and step away from Amazon. Interally we are already 1.5 year on Ubuntu (own ami). Would be great if we can add via a second PR support for arm as well. I have updated the examples, will push them asap. |
|
Getting the following error / warning in the log for ubuntu 24.0, however the runner gets healthy online and is being able run jobs. |
|
I have pushed changes on the example dir to this branch |
|
In summary:
|
@npalm : |
bdellegrazie
force-pushed
the
fix/ubuntu-24.04
branch
from
f4ed638
to
987a159
Compare
|
@npalm I have responded to your questions, please let me know if you require any more information. |
|
@bdellegrazie will check later this week. |
bdellegrazie
force-pushed
the
fix/ubuntu-24.04
branch
from
987a159
to
3165305
Compare
npalm
requested changes
Nov 20, 2024
On Ubuntu 24.04 there is another variable `ID_LIKE` that appears in the `/etc/os-release` file. This change fixes the regex match to only match ID and not ID_LIKE closes philips-labs#4245
bdellegrazie
force-pushed
the
fix/ubuntu-24.04
branch
from
2006c51
to
65b9267
Compare
* Switch to using the upstream deb archive for Docker * use awscli v2 * Provide a user-specific override for systemd * use machinectl to launch rootless docker
bdellegrazie
force-pushed
the
fix/ubuntu-24.04
branch
from
65b9267
to
410a7aa
Compare
|
@npalm I have made the change as requested - could you please re-review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 24.04 there is another variable
ID_LIKEthat appears in the/etc/os-releasefile. This change fixes the regex to only matchIDand notID_LIKEcloses #4245