fix: no connection with SSE version 1

httpmux.go

@@ -91,18 +91,18 @@ func (h *httpMux) handleGet(writer http.ResponseWriter, request *http.Request) {
 }
 
 func (h *httpMux) handleServerSentEvent(writer http.ResponseWriter, request *http.Request) {
-	connectionID := request.URL.Query().Get("id")
-	if connectionID == "" {
+	connectionIDorToken := request.URL.Query().Get("id")
+	if connectionIDorToken == "" {
 		writer.WriteHeader(http.StatusBadRequest)
 		return
 	}
 	h.mx.RLock()
-	c, ok := h.connectionMap[connectionID]
+	c, ok := h.connectionMap[connectionIDorToken]
 	h.mx.RUnlock()
 	if ok {
 		if _, ok := c.(*negotiateConnection); ok {
 			ctx, _ := onecontext.Merge(h.server.context(), request.Context())
-			sseConn, jobChan, jobResultChan, err := newServerSSEConnection(ctx, c.ConnectionID())
+			sseConn, jobChan, jobResultChan, err := newServerSSEConnection(ctx, connectionIDorToken) // version 1 uses the token to initiate the connection, not the ID
 			if err != nil {
 				writer.WriteHeader(http.StatusInternalServerError)
 				return

signalr_test/server_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"io"
+	"log"
 	"math/rand"
 	"net/http"
 	"os"
@@ -44,8 +45,12 @@ func TestMain(m *testing.M) {
 	os.Exit(m.Run())
 }
 
-func TestServerSmoke(t *testing.T) {
-	testServer(t, "^smoke", signalr.HTTPTransports("WebSockets"))
+func TestServerSmokeWebSockets(t *testing.T) {
+	testServer(t, "^smoke", signalr.HTTPTransports(signalr.TransportWebSockets))
+}
+
+func TestServerSmokeSSE(t *testing.T) {
+	testServer(t, "^smoke", signalr.HTTPTransports(signalr.TransportServerSentEvents))
 }
 
 func TestServerJsonWebSockets(t *testing.T) {
@@ -94,7 +99,7 @@ func runJest(t *testing.T, testNamePattern string, quitServer chan struct{}) {
 		t.Error(err, fmt.Sprintf("\n%s\n%s", outSlurp, errSlurp))
 	} else {
 		// Strange: Jest reports test results to stderr
-		t.Log(fmt.Sprintf("\n%s", errSlurp))
+		log.Printf("\n%s", errSlurp)
 	}
 }