Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen Patch + Bugfix #21

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Fullscreen Patch + Bugfix #21

wants to merge 41 commits into from

Conversation

ntninja
Copy link

@ntninja ntninja commented Aug 26, 2012

This patch fixes a bug that breaks the browser layout when the extension is being disabled without a restart. Also - and this is the important part - it adds the abilitity to hide the tabbar in fullscreen
mode.

@naturallymitchell
Copy link

Fullscreen is a great improvement, and I'm happy to have be using it. Thank you alexander255.

After about a day of use, I haven't experienced any bugs, though the 'Firefox menu' isn't always leaving the bottom of the vertical tab bar in all windows. I think https://addons.mozilla.org/en-US/firefox/addon/firefox-4-ui-fixer/ might be helpful for this problem and other bottom bar cleanup.

Applying the patch was only mildly difficult with the diffing, unzipping, and re-zipping. install.rdf had some rejections, so I kept the original.

@Luckz
Copy link

Luckz commented Nov 8, 2012

With this patch, does actually moving tabs up/down work again in recent Firefox versions?

@ntninja
Copy link
Author

ntninja commented Nov 16, 2012

I don't know about your version but it works for me... I can however remember fixing some issues that caused "Vertical Tabs" not to reload correctly.

Looking at the committed source, the change from

tabs.addEventListener('dragover', this.onDragOver, false);

to

this.tabs.addEventListener('dragover', this.onDragOver, false);

seems to confirm this, so please check :-) It's very likely!

Yours,
Alexander

@ntninja
Copy link
Author

ntninja commented Nov 16, 2012

In order to try it: Just download my branch as a zip-file, rename it to .xpi and open in Firefox

@philikon
Copy link
Owner

philikon commented Jan 8, 2013

Thanks for your patch! Sorry for taking so long to respond. Unfortunately, when going fullscreen (e.g. to watch a video), the tab bar is still there for me.

reuben and others added 25 commits February 17, 2014 16:47
Fix OS X theme on Australis. Pinned tabs still weird.
Bug 979479 added dynamic tooltips, including keyboard shortcuts, to
various buttons; this change needs to be reflected in the overridden
XUL.  Before updating, this manifested itself as tabs overlaid on each
other, and the error message "undefined entity" (referring to the old
tooltiptext).

See http://hg.mozilla.org/mozilla-central/rev/4dc06a48ed13.
Thank you!

* Replace tooltiptext with updated dynamic tooltip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants