Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality checker (Update on PR #170) #3

Merged
merged 8 commits into from
Oct 26, 2024
Merged

Conversation

philcaz
Copy link
Owner

@philcaz philcaz commented Oct 26, 2024

An update on PR JabRef#170 on upstream

Key Improvements:

  • Previously checker functions inefficiently read csv file at each call. Now we load each csv file into memory once, then pass it to check functions.
  • Reduce error summary size (but still too large to be directly seen on GitHub Action Summary)

image

philcaz and others added 8 commits October 27, 2024 03:40
Content of each abbreviation csv is now loaded into memory once and used by check functions, instead of being read multiple times upon function calls
Attempt to write issue report to GITHUB_STEP_SUMMARY
Fix quality checker name error
Try uploading large error report as artifect
Shorten error/warning message for smaller summary size
Shorten message and provide a more efficient error summary
@philcaz philcaz merged commit 1847689 into main Oct 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants