Improvements to music visualization using just artwork #199
Conversation
da-anda
force-pushed
the
artistslideshow2
branch
2 times, most recently
from
ed4900d to
ac07c86
Compare
|
I think I managed to add the setting. Just not sure about the label. Should we make it specific to artistslideshow, or do we want it more generic? |
|
Option should get moved to Custom_1105_MusicOSDSettings.xml, and should probably apply to non-script background as well. |
xml/MusicVisualisation.xml
Outdated
| <aspectratio>scale</aspectratio> | ||
| <fadetime>400</fadetime> | ||
| <animation effect="fade" start="0" end="100" time="400">WindowOpen</animation> | ||
| <animation effect="fade" start="100" end="0" time="300">WindowClose</animation> | ||
| <texture background="true" colordiffuse="88FFFFFF">$INFO[Player.Art(fanart)]</texture> | ||
| <visible>!Skin.HasSetting(hide_background_fanart)</visible> | ||
| </control> | ||
| <control type="multiimage"> |
There was a problem hiding this comment.
put this control and the above one into a group and move the "shared" stuff to group level (like animations, depth)
xml/MusicVisualisation.xml
Outdated
| <loop>yes</loop> | ||
| <imagepath background="true">$INFO[Window(Visualisation).Property(ArtistSlideshow)]</imagepath> | ||
| <visible>System.HasAddon(script.artistslideshow)</visible> | ||
| <animation effect="zoom" start="110" end="130" center="auto" time="10000" tween="sine" easing="inout" pulse="true" condition="Skin.HasSetting(AnimateSlideshow)">Conditional</animation> |
There was a problem hiding this comment.
these 2 animations should get merged into a single one (example: https://github.com/phil65/skin.estuary/blob/master/xml/Home.xml#L37)
da-anda
force-pushed
the
artistslideshow2
branch
from
ac07c86 to
2000283
Compare
…but user wants background artwork
da-anda
changed the title
|
updated. I tried to combine the two animations, but Kodi seems to have issues with the tweeners and easing in this case (there is no variation of the animation in any form), so I kept the two separate tags. I added an additional commit that uses the poster/cover as fallback artwork if there is no fanart. It's looking way better than just the colored background, and if somebody doesn't want the artwork it'll also be hidden ofc. |
|
good to go now? |
|
bump |
|
I learned yesterday that this repository is unmaintained and you need to propose this change to the upstream https://github.com/xbmc/xbmc repository. Good luck ! |
This adds support for the artistslideshow addon. In addition it fixes 3D depths of the viz background. Can remove the later change if desired.
I'd like to add a setting that allows to animate the slideshow in the background, wasn't sure though where to place it best and how to do this correctly. Suggestions welcome.