v2.4.25 #1038
Merged
v2.4.25 #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the updated prompt show good results with model 'qwen2' which sometimes just returning the JSON tool result
Push `Ollama` to its limits
… calls - Handled cases where models add text descriptions to tool call JSON - Handled cases where models split tool calls into multiple JSON objects
Push Ollama to its limits, improve ollama using tool results prompt and instructions to generate tool calls
CorrM
reviewed
Jul 3, 2024
phi/llm/ollama/chat.py
Outdated
| @@ -257,8 +284,10 @@ def response_stream(self, messages: List[Message]) -> Iterator[str]: | |||
| assistant_message_content += response_content | |||
|
|
|||
| # Strip out tool calls from the response | |||
| # If the response is a tool call, it will start with a { | |||
| if not response_is_tool_call and assistant_message_content.strip().startswith("{"): | |||
| extract_tool_calls_result = _extract_tool_calls(assistant_message_content) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch for testing this PR: #1029