Skip to content

Commit

Permalink
[Enterprise Search][Connectors] Update depends_on for Jira and Conflu…
Browse files Browse the repository at this point in the history
…ence connectors configs (elastic#170506)

## Summary

I spotted that `use_document_level_security` config for Jira and
Confluence native connectors is not respecting `depends_on` defined in
connectors framework - and it might lead to buggy behaviour in certain
edge case. I updated the config to match the source of truth.

Source of truth config:
-
[Jira](https://github.com/elastic/connectors/blob/main/connectors/sources/jira.py#L388)
- [Confluence
config](https://github.com/elastic/connectors/blob/main/connectors/sources/confluence.py#L313)
  • Loading branch information
jedrazb authored Nov 3, 2023
1 parent c41bd2e commit 4538046
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions packages/kbn-search-connectors/types/native_connectors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,12 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
},
use_document_level_security: {
default_value: null,
depends_on: [],
depends_on: [
{
field: 'data_source',
value: 'confluence_cloud',
},
],
display: DisplayType.TOGGLE,
label: ENABLE_DOCUMENT_LEVEL_SECURITY_LABEL,
options: [],
Expand Down Expand Up @@ -1224,7 +1229,12 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
},
use_document_level_security: {
default_value: null,
depends_on: [],
depends_on: [
{
field: 'data_source',
value: 'jira_cloud',
},
],
display: DisplayType.TOGGLE,
label: ENABLE_DOCUMENT_LEVEL_SECURITY_LABEL,
options: [],
Expand Down

0 comments on commit 4538046

Please sign in to comment.